feat[venom]: tune function inliner#4584
Merged
charles-cooper merged 1 commit intovyperlang:masterfrom Apr 17, 2025
Merged
Conversation
this commit tunes the function inliner by assigning `param` and `ret` instructions a cost of 0 (in fact, they should probably have negative cost, since those only have cost in the call convention overhead, but when inlined, they disappear).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4584 +/- ##
==========================================
+ Coverage 92.64% 92.67% +0.03%
==========================================
Files 122 122
Lines 17530 17537 +7
Branches 2980 2981 +1
==========================================
+ Hits 16240 16252 +12
+ Misses 892 888 -4
+ Partials 398 397 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
harkal
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this commit tunes the function inliner by assigning
paramandretinstructions a cost of 0 (in fact, they should probably have negative cost, since those only have cost in the call convention overhead, but when inlined, they disappear).What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture