feat[venom]: improve dload/mstore merging#4570
Merged
charles-cooper merged 29 commits intovyperlang:masterfrom Apr 28, 2025
Merged
feat[venom]: improve dload/mstore merging#4570charles-cooper merged 29 commits intovyperlang:masterfrom
dload/mstore merging#4570charles-cooper merged 29 commits intovyperlang:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4570 +/- ##
==========================================
+ Coverage 92.43% 92.49% +0.05%
==========================================
Files 127 127
Lines 18353 18371 +18
Branches 3178 3180 +2
==========================================
+ Hits 16965 16992 +27
+ Misses 947 939 -8
+ Partials 441 440 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HodanPlodky
changed the title
vyper/venom/passes/memmerging.py
Outdated
| producer.make_nop() | ||
| self.updater.add_before(store, "dloadbytes", [IRLiteral(32), src, dst]) | ||
| self.updater.update(store, "mload", [dst], new_output=producer.output) | ||
| self.updater.nop(producer, ignore_uses=True) |
Member
There was a problem hiding this comment.
i guess this is safe since we have temporarily taken the code out of SSA (on the previous line) right?
Collaborator
Author
There was a problem hiding this comment.
yes thats the idea
charles-cooper
changed the title
charles-cooper
changed the title
dload/mstore merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture