refactor[parser]: put settings on Module AST node#4569
Merged
charles-cooper merged 7 commits intovyperlang:masterfrom Apr 10, 2025
Merged
refactor[parser]: put settings on Module AST node#4569charles-cooper merged 7 commits intovyperlang:masterfrom
charles-cooper merged 7 commits intovyperlang:masterfrom
Conversation
remove `parse_to_ast_with_settings`, and replace it with directly putting the settings parsed from the pragmas on the AST. this allows us to respect pragmas on a file-by-file basis if needed.
it's duplicated with vyper/ast/utils.py
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4569 +/- ##
==========================================
+ Coverage 92.58% 92.66% +0.07%
==========================================
Files 123 123
Lines 17528 17516 -12
Branches 2969 2967 -2
==========================================
+ Hits 16229 16231 +2
+ Misses 894 883 -11
+ Partials 405 402 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cyberthirst
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture