fix[lang]: block modules in structs#4566
Merged
charles-cooper merged 5 commits intovyperlang:masterfrom Apr 11, 2025
Merged
Conversation
| _attribute_in_annotation = True | ||
| _as_array = False | ||
| _as_hashmap_key = False | ||
| _as_tuple_member = False |
Member
There was a problem hiding this comment.
i don't think this is defined in the base class or used anywhere in the PR?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4566 +/- ##
==========================================
+ Coverage 92.58% 92.66% +0.07%
==========================================
Files 123 123
Lines 17528 17526 -2
Branches 2969 2971 +2
==========================================
+ Hits 16229 16241 +12
+ Misses 894 883 -11
+ Partials 405 402 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
addressed cb2ffbc |
charles-cooper
changed the title
charles-cooper
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
modules could have been instantiated
a further question is whether to refactor location validation - a module can't be instantiated in storage, yet it's possible as shown in the example above. the location check should also recurse on the subtypes. i'm for refactor as it will help prevent potential future bugs
Commit Message