feat[lang]: remove @external decorator from builtin interfaces#4562
Merged
charles-cooper merged 1 commit intovyperlang:masterfrom Apr 7, 2025
Merged
Conversation
in interfaces, `@external` is already implicit. also, in error messages, not having the extra line helps with context
charles-cooper
changed the title
@external decorator from builtin interfaces
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4562 +/- ##
=======================================
Coverage 92.56% 92.56%
=======================================
Files 123 123
Lines 17467 17467
Branches 2950 2950
=======================================
Hits 16169 16169
Misses 894 894
Partials 404 404 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cyberthirst
approved these changes
Apr 7, 2025
Collaborator
cyberthirst
left a comment
cyberthirst
left a comment
There was a problem hiding this comment.
grep on interfaces/ leaves no hit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in interfaces,
@externalis already implicit. also, in error messages, not having the extra line helps with contextparticularly in the context of #4359, the
@viewdecorator gets cut off without this PR.What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture