feat[lang]!: remove deprecated bitwise builtins#4552
Merged
charles-cooper merged 3 commits intovyperlang:masterfrom Apr 5, 2025
Merged
feat[lang]!: remove deprecated bitwise builtins#4552charles-cooper merged 3 commits intovyperlang:masterfrom
charles-cooper merged 3 commits intovyperlang:masterfrom
Conversation
Collaborator
Author
|
maybe we should move some of the docs to the operator part |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4552 +/- ##
==========================================
+ Coverage 92.35% 92.56% +0.21%
==========================================
Files 123 123
Lines 17543 17467 -76
Branches 2961 2950 -11
==========================================
- Hits 16201 16169 -32
+ Misses 938 894 -44
Partials 404 404 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| Bitwise Operations | ||
| ================== | ||
|
|
||
| .. py:function:: bitwise_and(x: uint256, y: uint256) -> uint256 |
Member
There was a problem hiding this comment.
we should add a comment like
.. note::
The functions ``bitwise_and``, ``bitwise_or``, ``bitwise_xor`` and ``bitwise_not`` have been removed in Vyper 0.4.2. Please use their operator versions instead: ``&``, ``|``, ``^``, ``~``.
Member
There was a problem hiding this comment.
maybe also add that it was deprecated since 0.3.4
charles-cooper
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did