feat[lang]: remove one-warning limit from builtins#4542
Merged
charles-cooper merged 4 commits intovyperlang:masterfrom Apr 7, 2025
Merged
Conversation
remove the one-warning limit from most builtins, especially deprecation warnings. `breakpoint()` and `print()` are left as exceptions, since those might be peppered into a codebase while debugging, and the compiler does not need to be so verbose
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4542 +/- ##
=======================================
Coverage 92.56% 92.57%
=======================================
Files 123 123
Lines 17467 17452 -15
Branches 2950 2945 -5
=======================================
- Hits 16169 16156 -13
Misses 894 894
+ Partials 404 402 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
can you please add a test where we'd catch the same warning multiple times? |
Member
Author
|
cyberthirst
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove the one-warning limit from most builtins, especially deprecation warnings.
breakpoint()andprint()are left as exceptions, since those might be peppered into a codebase while debugging, and the compiler does not need to be so verboseWhat I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture