feat[lang]: bubble up create revertdata#4540
Merged
charles-cooper merged 7 commits intovyperlang:masterfrom Mar 30, 2025
Merged
feat[lang]: bubble up create revertdata#4540charles-cooper merged 7 commits intovyperlang:masterfrom
charles-cooper merged 7 commits intovyperlang:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4540 +/- ##
==========================================
- Coverage 92.37% 92.35% -0.03%
==========================================
Files 123 123
Lines 17538 17543 +5
Branches 2961 2961
==========================================
+ Hits 16200 16201 +1
- Misses 934 938 +4
Partials 404 404 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cyberthirst
approved these changes
Mar 29, 2025
Collaborator
pcaversaccio
left a comment
pcaversaccio
left a comment
There was a problem hiding this comment.
This PR is incomplete IMO as there is no way to handle specifically the revert data as a user. I made a proposal here to use a kwarg: #4147. Open for other suggestions, but similar to return_data, revert_data should be available for the create_ built-ins if requested by the user. I will reopen the issue again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
failed creates now bubble up revert data. fixes #4147
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture