refactor[test]: remove selfdestruct from example contracts#4537
refactor[test]: remove selfdestruct from example contracts#4537charles-cooper merged 12 commits intovyperlang:masterfrom
selfdestruct from example contracts#4537Conversation
|
looking at our |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4537 +/- ##
==========================================
- Coverage 92.55% 92.44% -0.11%
==========================================
Files 123 127 +4
Lines 17506 18308 +802
Branches 2962 3174 +212
==========================================
+ Hits 16202 16925 +723
- Misses 898 946 +48
- Partials 406 437 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cyberthirst
changed the title
selfdestruct from example contractsselfdestruct from example contracts
cyberthirst
changed the title
selfdestruct from example contractsselfdestruct from example contracts
| a0 = env.accounts[0] | ||
| val = 10 | ||
| env.set_balance(env.deployer, val) | ||
| c = get_contract(contract, a0, value=val) |
There was a problem hiding this comment.
can we add a check_warnings here
There was a problem hiding this comment.
sorry, catch_warnings -- and check the warning!
|
as per suggestion from @charles-cooper we'll emphasize that builtins should be stateless and I'll remove the state reset added in 3f5eaa5 instead we'll remove warning limit here #4542 and will enforce statelessness in the future |
charles-cooper
left a comment
charles-cooper
left a comment
There was a problem hiding this comment.
could add another assert to each test, otherwise lgtm
Co-authored-by: Charles Cooper <[email protected]>
Co-authored-by: Charles Cooper <[email protected]>
2 participants
What I did
selfdestructand replaced them with a lock + sendHow to verify it
selfdestructtests to compensate for their removal from the examplesCommit message
Description for the changelog
Cute Animal Picture