Skip to content

refactor[parser]: refactor pragma parsing#4530

Merged
charles-cooper merged 3 commits intovyperlang:masterfrom
charles-cooper:refactor/preparser
Apr 6, 2025
Merged

refactor[parser]: refactor pragma parsing#4530
charles-cooper merged 3 commits intovyperlang:masterfrom
charles-cooper:refactor/preparser

Conversation

@charles-cooper
Copy link
Copy Markdown
Member

move pragma parsing into its own subroutine

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

move pragma parsing into its own subroutine
@cyberthirst
Copy link
Copy Markdown
Collaborator

approved without review

@charles-cooper charles-cooper changed the title refactor[ast]: refactor pragma parsing refactor[parser]: refactor pragma parsing Mar 19, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 87.87879% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.27%. Comparing base (94cf162) to head (61b5715).
Report is 105 commits behind head on master.

Files with missing lines Patch % Lines
vyper/ast/pre_parser.py 87.87% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4530   +/-   ##
=======================================
  Coverage   92.27%   92.27%           
=======================================
  Files         123      123           
  Lines       17520    17522    +2     
  Branches     2961     2961           
=======================================
+ Hits        16166    16168    +2     
  Misses        946      946           
  Partials      408      408           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charles-cooper charles-cooper merged commit 6a00171 into vyperlang:master Apr 6, 2025
160 of 161 checks passed
@charles-cooper charles-cooper deleted the refactor/preparser branch April 6, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants