Skip to content

feat[venom]: make revert a bb terminator#4529

Merged
charles-cooper merged 5 commits intovyperlang:masterfrom
charles-cooper:feat/revert-terminator
Mar 19, 2025
Merged

feat[venom]: make revert a bb terminator#4529
charles-cooper merged 5 commits intovyperlang:masterfrom
charles-cooper:feat/revert-terminator

Conversation

@charles-cooper
Copy link
Copy Markdown
Member

@charles-cooper charles-cooper commented Mar 18, 2025 •
edited
Loading

What I did

How I did it

How to verify it

Commit message

this commit makes `revert` a basic block terminator. previously
`revert` was left as a non-terminating instruction since there could
be the possibility of reordering. however, since it terminates, it is
cleaner to disallow any control flow after the `revert` instruction.

it also fixes a minor bug discovered in `ir_node_to_venom`, where the
translator was appending instructions after a `revert` instruction (it
would have been appending them to a dead block in any case).

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.28%. Comparing base (94cf162) to head (c9be651).
Report is 86 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4529      +/-   ##
==========================================
+ Coverage   92.27%   92.28%   +0.01%     
==========================================
  Files         123      123              
  Lines       17520    17493      -27     
  Branches     2961     2952       -9     
==========================================
- Hits        16166    16143      -23     
+ Misses        946      944       -2     
+ Partials      408      406       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charles-cooper charles-cooper changed the title Feat/revert terminator feat[venom]: make revert a bb terminator Mar 19, 2025
@charles-cooper charles-cooper marked this pull request as ready for review March 19, 2025 10:59
@charles-cooper charles-cooper enabled auto-merge (squash) March 19, 2025 10:59
@charles-cooper charles-cooper merged commit 6414135 into vyperlang:master Mar 19, 2025
159 checks passed
@tintinweb tintinweb mentioned this pull request Mar 23, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harkal harkal harkal approved these changes

@HodanPlodky HodanPlodky Awaiting requested review from HodanPlodky

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charles-cooper @harkal