Skip to content

refactor[venom]: simplify SimplifyCFG pass#4528

Merged
charles-cooper merged 1 commit intovyperlang:masterfrom
charles-cooper:refactor/venom/simplify_cfg
Mar 21, 2025
Merged

refactor[venom]: simplify SimplifyCFG pass#4528
charles-cooper merged 1 commit intovyperlang:masterfrom
charles-cooper:refactor/venom/simplify_cfg

Conversation

@charles-cooper
Copy link
Copy Markdown
Member

@charles-cooper charles-cooper commented Mar 18, 2025

What I did

How I did it

How to verify it

Commit message

remove unreachable code. the `_optimize_empty_basicblocks` was actually
a no-op, since venom doesn't allow empty basic blocks as they are
non-terminated.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

the `_optimize_empty_basicblocks` was actually a no-op, since venom
doesn't allow empty basic blocks as they are non-terminated.
@charles-cooper charles-cooper requested a review from harkal March 18, 2025 11:18
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.32%. Comparing base (fc2473c) to head (1311835).
Report is 94 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4528      +/-   ##
==========================================
+ Coverage   92.26%   92.32%   +0.06%     
==========================================
  Files         123      123              
  Lines       17502    17479      -23     
  Branches     2960     2956       -4     
==========================================
- Hits        16148    16138      -10     
+ Misses        946      935      -11     
+ Partials      408      406       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charles-cooper charles-cooper merged commit 18d0787 into vyperlang:master Mar 21, 2025
162 checks passed
@charles-cooper charles-cooper deleted the refactor/venom/simplify_cfg branch March 21, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants