fix[venom]: fix var defined check for unreachable blocks#4518
Merged
charles-cooper merged 43 commits intovyperlang:masterfrom Mar 18, 2025
Merged
fix[venom]: fix var defined check for unreachable blocks#4518charles-cooper merged 43 commits intovyperlang:masterfrom
charles-cooper merged 43 commits intovyperlang:masterfrom
Conversation
… into feat/venom/basic-check
… into feat/venom/basic-check
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4518 +/- ##
=======================================
Coverage 92.26% 92.26%
=======================================
Files 123 123
Lines 17502 17505 +3
Branches 2960 2961 +1
=======================================
+ Hits 16148 16151 +3
Misses 946 946
Partials 408 408 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@HodanPlodky could you rebase off master? |
charles-cooper
approved these changes
Mar 18, 2025
charles-cooper
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fixed error that was triggered with unreachable basic block in var definition analysis
How I did it
Run analysis on all basic block not just unreachable and fix a lattice
How to verify it
Added test for this case
Commit message
Description for the changelog
Cute Animal Picture