Skip to content

refactor[venom]: update more passes to use InstUpdater#4516

Merged
charles-cooper merged 23 commits intovyperlang:masterfrom
charles-cooper:refactor/venom/more-inst-updater
Apr 10, 2025
Merged

refactor[venom]: update more passes to use InstUpdater#4516
charles-cooper merged 23 commits intovyperlang:masterfrom
charles-cooper:refactor/venom/more-inst-updater

Conversation

@charles-cooper
Copy link
Copy Markdown
Member

@charles-cooper charles-cooper commented Mar 12, 2025 •
edited
Loading

What I did

How I did it

How to verify it

Commit message

this commit updates more passes to use `InstUpdater`.

additionally:

- added `nop_multi()`, which can be used to delete a "batch" of
  instructions, where nop'ing them individually may trip the assertion
  in `InstUpdater.update()`.

- added `new_output=` kwarg to `InstUpdater.update()`, to allow setting
  the output of the instruction.

- found a latent bug in `MakeSSA` (it was not invalidating the dfg,
  which was only tripped after updating `LowerDLoadPass` to not
  invalidate the dfg).

- fixed a latent bug in `InstUpdater.update()` - it did not delete the
  op from dfg_outputs after update.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.50746% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.58%. Comparing base (190a9c7) to head (dbaadf3).
Report is 86 commits behind head on master.

Files with missing lines Patch % Lines
vyper/venom/passes/mem2var.py 90.90% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4516      +/-   ##
==========================================
+ Coverage   92.55%   92.58%   +0.03%     
==========================================
  Files         123      123              
  Lines       17506    17528      +22     
  Branches     2962     2969       +7     
==========================================
+ Hits        16202    16229      +27     
+ Misses        898      894       -4     
+ Partials      406      405       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charles-cooper charles-cooper marked this pull request as ready for review March 12, 2025 20:00
@charles-cooper charles-cooper changed the title refactor[venom]: update more passes to use InstUpdater refactor[venom]: update more passes to use InstUpdater Mar 28, 2025
@charles-cooper charles-cooper enabled auto-merge (squash) April 10, 2025 11:15
@charles-cooper charles-cooper disabled auto-merge April 10, 2025 11:28
@charles-cooper charles-cooper enabled auto-merge (squash) April 10, 2025 11:52
@charles-cooper charles-cooper merged commit 0835158 into vyperlang:master Apr 10, 2025
159 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harkal harkal harkal approved these changes

@HodanPlodky HodanPlodky HodanPlodky approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@charles-cooper @harkal @HodanPlodky