Skip to content

feat[venom]: allow labels to be assigned to variables#4514

Merged
charles-cooper merged 11 commits intovyperlang:masterfrom
harkal:feat/label_assignment
Mar 14, 2025
Merged

feat[venom]: allow labels to be assigned to variables#4514
charles-cooper merged 11 commits intovyperlang:masterfrom
harkal:feat/label_assignment

Conversation

@harkal
Copy link
Copy Markdown
Collaborator

@harkal harkal commented Mar 12, 2025 •
edited by charles-cooper
Loading

What I did

How I did it

How to verify it

Commit message

this commit allows labels to be assigned to variables. it updates
assumptions in `SCCP` and the venom parser which blocked that behavior.

it also updates the text format for `djmp` to be like `jnz` (condition
is first). it also fixes a bug in SimplifyCFG where `merge_jump` did
not rename label operands.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.22%. Comparing base (41108f9) to head (be848a2).
Report is 85 commits behind head on master.

Files with missing lines Patch % Lines
vyper/venom/basicblock.py 75.00% 1 Missing ⚠️
vyper/venom/parser.py 50.00% 0 Missing and 1 partial ⚠️
vyper/venom/passes/simplify_cfg.py 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4514      +/-   ##
==========================================
+ Coverage   92.15%   92.22%   +0.07%     
==========================================
  Files         123      123              
  Lines       17469    17472       +3     
  Branches     2957     2955       -2     
==========================================
+ Hits        16099    16114      +15     
+ Misses        958      946      -12     
  Partials      412      412

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

charles-cooper
charles-cooper approved these changes Mar 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, needs a test

@charles-cooper charles-cooper marked this pull request as ready for review March 12, 2025 13:10
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 12, 2025
View reviewed changes
@charles-cooper charles-cooper merged commit 2360d62 into vyperlang:master Mar 14, 2025
161 of 162 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charles-cooper charles-cooper charles-cooper approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@harkal @charles-cooper @github-advanced-security