refactor[test]: add more tests with hevm venom harness#4493
refactor[test]: add more tests with hevm venom harness#4493charles-cooper merged 70 commits intovyperlang:masterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4493 +/- ##
=======================================
Coverage 92.04% 92.04%
=======================================
Files 120 120
Lines 17361 17361
Branches 2940 2940
=======================================
Hits 15980 15980
Misses 964 964
Partials 417 417 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
charles-cooper
changed the title
| self.pass_objects = list() | ||
|
|
||
| def __call__(self, pre: str, post: str, hevm: bool | None = None) -> list[IRPass]: | ||
| from tests.hevm import hevm_check_venom |
Check notice
Code scanning / CodeQL
Cyclic import Note test
tests/venom_utils.py
Outdated
| pass_objects: list[IRPass] | ||
| default_hevm: bool | ||
|
|
||
| def __init__(self, *passes, post: list[type] | None = None, default_hevm: bool = True): |
There was a problem hiding this comment.
bit odd that pre passes are passed as varargs but post passes are passed as a list
There was a problem hiding this comment.
I did this like that because in most cases there are only pre passes and post are added as something that is only occasionally added. But if you would think that it should be same then for sure I could switch it.
| jmp @join | ||
| join: | ||
| %3 = phi @then, %1, @else, %2 | ||
| stop |
There was a problem hiding this comment.
maybe we should sink %3 here, otherwise hevm will trivially validate it
…r into chore/venom/test-update
…r into chore/venom/test-update
…r into chore/venom/test-update
…r into chore/venom/test-update
3 participants
What I did
Added hevm harness to more venom tests
How I did it
rewrote tests to venom text format if needed and used hevm harness
How to verify it
Commit message
Description for the changelog
Cute Animal Picture