fix[parser]: block value assignment in for targets#4492
Merged
charles-cooper merged 5 commits intovyperlang:masterfrom Mar 11, 2025
Merged
fix[parser]: block value assignment in for targets#4492charles-cooper merged 5 commits intovyperlang:masterfrom
charles-cooper merged 5 commits intovyperlang:masterfrom
Conversation
block statements of the form `for x: uint256 = 5 in ...`; it should not be allowed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4492 +/- ##
=======================================
Coverage 92.04% 92.04%
=======================================
Files 120 120
Lines 17362 17364 +2
Branches 2941 2942 +1
=======================================
+ Hits 15981 15983 +2
Misses 964 964
Partials 417 417 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Mar 5, 2025
cyberthirst
approved these changes
Mar 11, 2025
Collaborator
cyberthirst
left a comment
cyberthirst
left a comment
There was a problem hiding this comment.
lgtm, let's just please merge: charles-cooper#62
…r/for-annotation add syntax tests for for annotation
charles-cooper
changed the title
charles-cooper
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture