refactor[lang]: refactor decorator parsing#4490
Merged
charles-cooper merged 12 commits intovyperlang:masterfrom Mar 11, 2025
Merged
refactor[lang]: refactor decorator parsing#4490charles-cooper merged 12 commits intovyperlang:masterfrom
charles-cooper merged 12 commits intovyperlang:masterfrom
Conversation
minor refactor of decorator parsing, which simplifies the code and should make it easier to add new builtin decorators in the future
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4490 +/- ##
==========================================
+ Coverage 92.11% 92.16% +0.04%
==========================================
Files 122 122
Lines 17455 17475 +20
Branches 2961 2962 +1
==========================================
+ Hits 16079 16105 +26
+ Misses 962 958 -4
+ Partials 414 412 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
didn't look into it closely, but can't we use the new machinery in |
cyberthirst
reviewed
Mar 10, 2025
cyberthirst
reviewed
Mar 10, 2025
Member
Author
no, those have a different machinery since functions in interface declarations don't use decorators |
…vyper into feat/refactor-decorators
cyberthirst
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture