feat[venom]: add basic semantic check machinery to venom#4483
Merged
charles-cooper merged 37 commits intovyperlang:masterfrom Mar 11, 2025
Merged
feat[venom]: add basic semantic check machinery to venom#4483charles-cooper merged 37 commits intovyperlang:masterfrom
charles-cooper merged 37 commits intovyperlang:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4483 +/- ##
==========================================
- Coverage 92.04% 92.04% -0.01%
==========================================
Files 120 122 +2
Lines 17362 17453 +91
Branches 2941 2960 +19
==========================================
+ Hits 15981 16064 +83
- Misses 964 972 +8
Partials 417 417 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
… into feat/venom/basic-check
This reverts commit 467c321.
charles-cooper
changed the title
| assert [err.inst.parent.label.name for err in errors] == ["after"] | ||
|
|
||
|
|
||
| def test_venom_parser_nonexistant_var_loop_incorrect_phi(): |
Member
There was a problem hiding this comment.
docstring / test description please!
Member
There was a problem hiding this comment.
it might be helpful to point out the difference between this test and the previous test, which only differ in one line
| assert [err.inst.parent.label.name for err in errors] == ["join", "join"] | ||
|
|
||
|
|
||
| def test_venom_parser_nonexistant_var_loop(): |
Member
There was a problem hiding this comment.
docstring / test description please!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture