fix[docs]: fix venom examples#4475
Merged
charles-cooper merged 9 commits intovyperlang:masterfrom Mar 13, 2025
Merged
Conversation
Member
|
@2xic is this ready for review? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4475 +/- ##
=======================================
Coverage 92.15% 92.15%
=======================================
Files 123 123
Lines 17469 17469
Branches 2957 2957
=======================================
Hits 16099 16099
Misses 958 958
Partials 412 412 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
Sorry, missed your comment. I'm hoping to update this PR sometime this week or next week and make it ready for review. Still some places in the readme that has to be updated, but playing around with some other parts of the IR now and want to make sure that is also correctly documented. |
Contributor
Author
Sorry it took so long, it should be ready for review now @charles-cooper |
charles-cooper
approved these changes
Mar 13, 2025
This reverts commit 8032740.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
I was playing around with the venom IR parser and ran into issues when using some of the instructions per the README. The current docs has swapped the usage of labels and the vars a few places.
How I did it
I got a error message which hinted at the issue
Then I ran the following on a Vyper file which would use the phi function to find a reference
It gave out
How to verify it
Per the docs, this should compile, but it doesn't
With my suggested fix it does compile
Using
python3 -m vyper.cli.venom_main [file]to verify. Same is true forjnzand the example code.Commit message
Description for the changelog
Cute Animal Picture