feat[test]: add hevm harness for venom passes#4460
Merged
charles-cooper merged 27 commits intovyperlang:masterfrom Feb 6, 2025
Merged
feat[test]: add hevm harness for venom passes#4460charles-cooper merged 27 commits intovyperlang:masterfrom
charles-cooper merged 27 commits intovyperlang:masterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4460 +/- ##
==========================================
- Coverage 92.11% 92.09% -0.02%
==========================================
Files 119 119
Lines 16933 16936 +3
Branches 2865 2866 +1
==========================================
+ Hits 15597 15598 +1
- Misses 917 919 +2
Partials 419 419 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
charles-cooper
force-pushed
the
feat/venom/hevm-equivalence
branch
from
ab27245 to
1e02f4c
Compare
HodanPlodky
reviewed
Feb 1, 2025
| # correct optimization: | ||
| self.updater._update(inst, "eq", [operands[1], IRLiteral(never)]) | ||
| # canary: | ||
| # self.updater._update(inst, "eq", [operands[1], IRLiteral(lo)]) |
Collaborator
There was a problem hiding this comment.
Do you want to leave this here or could be revert this?
Member
Author
There was a problem hiding this comment.
I'll leave it for people to review then remove
tests/hevm.py
Outdated
| ctx = parse_from_basic_block(venom_source_code) | ||
|
|
||
| num_calldataloads = 0 | ||
| num_return_values = 0 |
Collaborator
There was a problem hiding this comment.
you could remove this one right (num_return_values)?
Member
Author
There was a problem hiding this comment.
Yea, looks like it
harkal
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture