Skip to content

chore[ci]: separate codecov upload into separate job#4455

Merged
charles-cooper merged 6 commits intovyperlang:masterfrom
charles-cooper:ci/coverage-combine-step
Jan 20, 2025
Merged

chore[ci]: separate codecov upload into separate job#4455
charles-cooper merged 6 commits intovyperlang:masterfrom
charles-cooper:ci/coverage-combine-step

Conversation

@charles-cooper
Copy link
Copy Markdown
Member

@charles-cooper charles-cooper commented Jan 20, 2025 •
edited
Loading

What I did

How I did it

How to verify it

Commit message

this commit separates `coverage combine` (the local tool) and codecov
upload (upload to 3rd party app) into separate steps. it also uploads
the coverage report artifacts. this makes the actions more transparent
since we can download the coverage database to inspect it if there is
an issue, and allows us to set the `coverage report` as a required CI
check, which does not depend on a 3rd party service. (if it depended on
a 3rd party service, we might then be unable to merge PRs if there is
an issue on the 3rd party service's side).

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper changed the title separate coverage combine into separate step feat[ci]: separate coverage combine into separate step Jan 20, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.09%. Comparing base (9a2cb2e) to head (d853ec0).
Report is 73 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4455   +/-   ##
=======================================
  Coverage   92.09%   92.09%           
=======================================
  Files         119      119           
  Lines       16931    16931           
  Branches     2865     2865           
=======================================
  Hits        15593    15593           
  Misses        919      919           
  Partials      419      419

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charles-cooper charles-cooper marked this pull request as ready for review January 20, 2025 17:56
@charles-cooper charles-cooper changed the title feat[ci]: separate coverage combine into separate step chore[ci]: separate coverage combine into separate job Jan 20, 2025
@charles-cooper charles-cooper changed the title chore[ci]: separate coverage combine into separate job chore[ci]: separate coverage combine into separate job Jan 20, 2025
@charles-cooper charles-cooper changed the title chore[ci]: separate coverage combine into separate job chore[ci]: separate codecov upload into separate job Jan 20, 2025
cyberthirst
cyberthirst approved these changes Jan 20, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cyberthirst cyberthirst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve without review

@charles-cooper charles-cooper merged commit 4d693b7 into vyperlang:master Jan 20, 2025
@charles-cooper charles-cooper deleted the ci/coverage-combine-step branch January 20, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cyberthirst cyberthirst cyberthirst approved these changes

@tserg tserg Awaiting requested review from tserg

+1 more reviewer

@fubuloubu fubuloubu fubuloubu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@charles-cooper @fubuloubu @cyberthirst