Skip to content

chore[ci]: bump upload-artifact action to v4#4445

Merged
charles-cooper merged 12 commits intovyperlang:masterfrom
tserg:ci/artifacts
Jan 12, 2025
Merged

chore[ci]: bump upload-artifact action to v4#4445
charles-cooper merged 12 commits intovyperlang:masterfrom
tserg:ci/artifacts

Conversation

@tserg
Copy link
Copy Markdown
Contributor

@tserg tserg commented Jan 11, 2025

What I did

Fix #4441.

How I did it

How to verify it

Commit message

This commit bumps the upload-artifact action to v4 because
v3 will be deprecated on 30 Jan 2025.

Description for the changelog

Bump upload-artifact action to v4

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.98%. Comparing base (f444c8f) to head (baba209).
Report is 76 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4445   +/-   ##
=======================================
  Coverage   91.98%   91.98%           
=======================================
  Files         119      119           
  Lines       16686    16686           
  Branches     2808     2808           
=======================================
  Hits        15348    15348           
  Misses        919      919           
  Partials      419      419           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tserg
Copy link
Copy Markdown
Contributor Author

tserg commented Jan 11, 2025

How can I test this?

# TODO: this needs to be tested when upgrading to upload-artifact v4
working-directory: artifacts/artifact
run: |
set -Eeuxo pipefail
for BIN_NAME in $(ls)
do
curl -L \
--no-progress-meter \
-X POST \
-H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}"\
-H "Content-Type: application/octet-stream" \
"https://uploads.github.com/repos/${{ github.repository }}/releases/${{ github.event.release.id }}/assets?name=${BIN_NAME/+/%2B}" \
--data-binary "@${BIN_NAME}"
done

@charles-cooper
Copy link
Copy Markdown
Member

How can I test this?

# TODO: this needs to be tested when upgrading to upload-artifact v4
working-directory: artifacts/artifact
run: |
set -Eeuxo pipefail
for BIN_NAME in $(ls)
do
curl -L \
--no-progress-meter \
-X POST \
-H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}"\
-H "Content-Type: application/octet-stream" \
"https://uploads.github.com/repos/${{ github.repository }}/releases/${{ github.event.release.id }}/assets?name=${BIN_NAME/+/%2B}" \
--data-binary "@${BIN_NAME}"
done

check the build artifacts actions -- ex. https://github.com/vyperlang/vyper/actions/runs/12720146923/job/35461412257?pr=4445

@tserg
Copy link
Copy Markdown
Contributor Author

tserg commented Jan 11, 2025

I have made some changes and verified it is working.

Copy link
Copy Markdown
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, we should merge before the next rc

@charles-cooper charles-cooper enabled auto-merge (squash) January 12, 2025 16:34
@charles-cooper charles-cooper merged commit 10e91d5 into vyperlang:master Jan 12, 2025
@tserg tserg deleted the ci/artifacts branch January 13, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore[ci]: github artifact actions to be deprecated on jan 30

2 participants