fix[ux]: fix error message for "staticall" typo#4438
fix[ux]: fix error message for "staticall" typo#4438charles-cooper merged 7 commits intovyperlang:masterfrom
Conversation
|
the drawback of this approach is that if the bad keyword is separated from the next token by more than one line, the error message does not include the hint. wdyt @cyberthirst @pcaversaccio @fubuloubu ? @external
def foo():
staticall \
foo()@external
def foo():
staticall \
\
foo() |
|
I mean PEP-8 doesn't explicitly prohibit multiple consecutive blank lines within a block of code, but the principle of "Readability counts." (and minimal clutter) implies that more than one consecutive blank line is completely unnecessary. Thus, having such insane line breaks: @external
def foo():
staticall \
\
foo() is not really a pattern that we should support and I'm ok with the drawback of this approach. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4438 +/- ##
===========================================
- Coverage 91.94% 49.79% -42.15%
===========================================
Files 119 119
Lines 16677 16684 +7
Branches 2807 2809 +2
===========================================
- Hits 15333 8308 -7025
- Misses 924 7737 +6813
- Partials 420 639 +219 ☔ View full report in Codecov by Sentry. |


What I did
alternative approach to #4363
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture