Skip to content

feat[venom]: improve memmerge pass#4422

Merged
charles-cooper merged 52 commits intovyperlang:masterfrom
HodanPlodky:fix/memmerge-bytecodesize
Mar 25, 2025
Merged

feat[venom]: improve memmerge pass#4422
charles-cooper merged 52 commits intovyperlang:masterfrom
HodanPlodky:fix/memmerge-bytecodesize

Conversation

@HodanPlodky
Copy link
Copy Markdown
Collaborator

@HodanPlodky HodanPlodky commented Dec 23, 2024

What I did

Improvements in memmerge pass so the barriers dont need to flush all the copies. This was done in response to issue #4420

How I did it

How to verify it

Commit message

this commit improves the memmerging pass by only flushing invalidated
regions where possible, instead of always flushing everything on an
invalidation.

it refactors the memmerge pass, including splitting out the different
kinds of invalidations for clarity.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@HodanPlodky HodanPlodky marked this pull request as ready for review December 31, 2024 07:42
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 98.61111% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.36%. Comparing base (6ed37b8) to head (e07cbb2).
Report is 86 commits behind head on master.

Files with missing lines Patch % Lines
vyper/venom/passes/memmerging.py 98.61% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4422   +/-   ##
=======================================
  Coverage   92.35%   92.36%           
=======================================
  Files         123      123           
  Lines       17499    17527   +28     
  Branches     2949     2958    +9     
=======================================
+ Hits        16162    16189   +27     
- Misses        933      934    +1     
  Partials      404      404           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charles-cooper charles-cooper changed the title fix[venom]: memmerge bytecodesize feat[venom]: improve memmerge pass Mar 21, 2025
@charles-cooper charles-cooper enabled auto-merge (squash) March 25, 2025 09:05
@charles-cooper charles-cooper merged commit d9444fb into vyperlang:master Mar 25, 2025
159 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants