chore[docs]: nonpayable internal function behaviour#4416
Merged
charles-cooper merged 2 commits intovyperlang:masterfrom Dec 31, 2024
Merged
chore[docs]: nonpayable internal function behaviour#4416charles-cooper merged 2 commits intovyperlang:masterfrom
nonpayable internal function behaviour#4416charles-cooper merged 2 commits intovyperlang:masterfrom
Conversation
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
pcaversaccio
changed the title
nonpayable internal functions can be called via external payable functionsnonpayable internal function behaviour
Collaborator
|
can you please define in the docs what is means that an internal function is |
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
Collaborator
Author
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4416 +/- ##
===========================================
- Coverage 91.68% 51.46% -40.23%
===========================================
Files 116 119 +3
Lines 16481 16615 +134
Branches 2778 2794 +16
===========================================
- Hits 15111 8551 -6560
- Misses 939 7436 +6497
- Partials 431 628 +197 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cyberthirst
approved these changes
Dec 30, 2024
charles-cooper
approved these changes
Dec 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Resolves #37584of Attackathon | Ethereum Protocol. Add a note to clarify that
nonpayableinternalfunctions can be called viaexternalpayablefunctions.How I did it
Brain.
How to verify it
Skills.
Commit message
Description for the changelog
Add a note to clarify that
nonpayableinternalfunctions can be called viaexternalpayablefunctions.Cute Animal Picture