chore[docs]: abi function signature for default arguments#4415
Merged
charles-cooper merged 3 commits intovyperlang:masterfrom Dec 31, 2024
Merged
chore[docs]: abi function signature for default arguments#4415charles-cooper merged 3 commits intovyperlang:masterfrom
charles-cooper merged 3 commits intovyperlang:masterfrom
Conversation
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
Collaborator
|
Looks good. Can we please add a note on what it means that an interface function contains a default parameter? ie that the semantics are that we're interfacing with a contract that supports the default arguments - it's dependant on the callee to implement it |
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
Collaborator
Author
|
cyberthirst
approved these changes
Dec 30, 2024
charles-cooper
approved these changes
Dec 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Resolves #37634 of Attackathon | Ethereum Protocol. Add a note on how the function signature is calculated if default arguments are used.
How I did it
Brain.
How to verify it
Check function signatures.
Commit message
Description for the changelog
Add a note on how the function signature is calculated if default arguments are used.
Cute Animal Picture