Skip to content

chore[docs]: abi function signature for default arguments#4415

Merged
charles-cooper merged 3 commits intovyperlang:masterfrom
pcaversaccio:docs/fn-sigs-default-args
Dec 31, 2024
Merged

chore[docs]: abi function signature for default arguments#4415
charles-cooper merged 3 commits intovyperlang:masterfrom
pcaversaccio:docs/fn-sigs-default-args

Conversation

@pcaversaccio
Copy link
Copy Markdown
Collaborator

@pcaversaccio pcaversaccio commented Dec 20, 2024

What I did

Resolves #37634 of Attackathon | Ethereum Protocol. Add a note on how the function signature is calculated if default arguments are used.

How I did it

Brain.

How to verify it

Check function signatures.

Commit message

this commit adds a note on how the function selector is calculated if
default arguments are used.

Description for the changelog

Add a note on how the function signature is calculated if default arguments are used.

Cute Animal Picture

image

@pcaversaccio pcaversaccio self-assigned this Dec 20, 2024
@pcaversaccio pcaversaccio added the documentation Documentation label Dec 20, 2024
@pcaversaccio pcaversaccio changed the title chore[docs]: ABI function signature for default arguments chore[docs]: abi function signature for default arguments Dec 20, 2024
@cyberthirst
Copy link
Copy Markdown
Collaborator

Looks good. Can we please add a note on what it means that an interface function contains a default parameter? ie that the semantics are that we're interfacing with a contract that supports the default arguments - it's dependant on the callee to implement it

Signed-off-by: Pascal Marco Caversaccio <[email protected]>
@pcaversaccio
Copy link
Copy Markdown
Collaborator Author

Looks good. Can we please add a note on what it means that an interface function contains a default parameter? ie that the semantics are that we're interfacing with a contract that supports the default arguments - it's dependant on the callee to implement it

b887862

@charles-cooper charles-cooper merged commit a29b49d into vyperlang:master Dec 31, 2024
@pcaversaccio pcaversaccio deleted the docs/fn-sigs-default-args branch December 31, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants