feat[venom]: update text format for data section#4414
Merged
charles-cooper merged 8 commits intovyperlang:masterfrom Dec 20, 2024
Merged
feat[venom]: update text format for data section#4414charles-cooper merged 8 commits intovyperlang:masterfrom
charles-cooper merged 8 commits intovyperlang:masterfrom
Conversation
use more structured classes in its internal representation remove dead branch in venom_to_assembly
update DataItem to implement __str__() instead of __repr__()
Collaborator
|
I believe that since we took the path of "higher level" syntax with curly brackets etc data_section readonly foo {
db @label
db x"abcd"
db @label 0xBEEF @label2 "a" ; support multiple data in one line version
} |
harkal
approved these changes
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
add cases for raw bytes (which are generated by
--optimize codesize) in data section. update parser to parse the new text format. refactor internal representation of data section to not use IRInstruction. remove xfail from previously passing test cases. tweak IRFunction repr to add the function name at close (helpful for debugging).this is a follow on to #4402.
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture