feat[venom]: remove special cases in store elimination#4413
Merged
charles-cooper merged 2 commits intovyperlang:masterfrom Dec 20, 2024
Merged
feat[venom]: remove special cases in store elimination#4413charles-cooper merged 2 commits intovyperlang:masterfrom
charles-cooper merged 2 commits intovyperlang:masterfrom
Conversation
remove special cases in store elimination, allowing elimination of %ret_ofst and %ret_size store chain. this was previously to protect correctness in `mem2var`, but it no longer seems to be needed. running an additional store elimination before `mem2var` results in a slight bytecode size improvement, since it allows more memory locations to be promoted to stack variables.
harkal
approved these changes
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture