feat[venom]: propagate dload instruction to venom#4410
Merged
charles-cooper merged 5 commits intovyperlang:masterfrom Dec 20, 2024
Merged
feat[venom]: propagate dload instruction to venom#4410charles-cooper merged 5 commits intovyperlang:masterfrom
dload instruction to venom#4410charles-cooper merged 5 commits intovyperlang:masterfrom
Conversation
this improves our ability to merge `dload/mstore` instructions. after the LowerDload pass, we have stripped dloads from the IR
charles-cooper
changed the title
charles-cooper
changed the title
dload instruction to venom
Member
Author
|
marking as draft since this introduces a regression which i am investigating |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4410 +/- ##
==========================================
+ Coverage 88.29% 88.98% +0.68%
==========================================
Files 116 117 +1
Lines 16475 16491 +16
Branches 2777 2778 +1
==========================================
+ Hits 14547 14674 +127
+ Misses 1388 1308 -80
+ Partials 540 509 -31 ☔ View full report in Codecov by Sentry. |
Member
Author
fixed in 24a6667 |
harkal
approved these changes
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture