feat[venom]: improve load elimination#4407
Merged
charles-cooper merged 52 commits intovyperlang:masterfrom Feb 12, 2025
Merged
Conversation
Fix lint Co-authored-by: Harry Kalogirou <[email protected]>
--------- Co-authored-by: HodanPlodky <[email protected]>
charles-cooper
force-pushed
the
feat/advanced-load-elimination
branch
from
f57aab3 to
0155857
Compare
charles-cooper
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4407 +/- ##
==========================================
+ Coverage 92.09% 92.12% +0.02%
==========================================
Files 119 119
Lines 16936 16967 +31
Branches 2866 2872 +6
==========================================
+ Hits 15598 15631 +33
+ Misses 919 918 -1
+ Partials 419 418 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HodanPlodky
reviewed
Jan 31, 2025
fix[venom]: test fixes
HodanPlodky
approved these changes
Feb 11, 2025
Co-authored-by: HodanPlodky <[email protected]>
harkal
approved these changes
Feb 12, 2025
Collaborator
harkal
left a comment
harkal
left a comment
There was a problem hiding this comment.
lgtm in general. If in the mood, I would:
- change the
self._latticeto be a local variable. - split the handling of load/store parts of the instruction look to separate methods for cleaner look
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
follow up to #4265 but generalize the lattice to multiple keys
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture