please add tests for all 3 error cases as they are listed in #4405

not very informative:

def test() -> Bytes[10]:
    a: Bytes[10] = x'gloglo'
    return a

ValueError: non-hexadecimal number found in fromhex() arg at position 0

crashes on our grammar:

def test_hexstring(get_contract):
    src = """
@external
def test() -> Bytes[10]:
    a: Bytes[10] = x \
    'baba'
    return a
    """

    c = get_contract(src)

    assert c.test() == b'\xba\xba'

what about we pop the hex_string_location in parse and assert at the end that the locations are empty? as a sanity check to prevent confusion between str and hexbytes

questionable, but maybe ok..

this compiles

def test() -> Bytes[10]:
    x: Bytes[10] = x'  10  '
    return x

what about we pop the hex_string_location in parse and assert at the end that the locations are empty? as a sanity check to prevent confusion between str and hexbytes

good idea, added here 24bb91d

Codecov Report

Attention: Patch coverage is 16.66667% with 15 lines in your changes missing coverage. Please review.

Project coverage is 44.91%. Comparing base (194d60a) to head (04faac3).
Report is 4 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (194d60a) and HEAD (04faac3). Click for more details.

HEAD has 137 uploads less than BASE

Flag	BASE (194d60a)	HEAD (04faac3)
	138	1

@@             Coverage Diff             @@
##           master    #4406       +/-   ##
===========================================
- Coverage   91.86%   44.91%   -46.96%     
===========================================
  Files         119      119               
  Lines       16640    16677       +37     
  Branches     2801     2806        +5     
===========================================
- Hits        15286     7490     -7796     
- Misses        929     8623     +7694     
- Partials      425      564      +139     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

questionable, but maybe ok..

this compiles

def test() -> Bytes[10]:
    x: Bytes[10] = x'  10  '
    return x

i'd say even if this is an issue, it's out of scope because it's not related to the tokenization changes in this PR