feat[venom]: cleanup variable version handling#4404
feat[venom]: cleanup variable version handling#4404charles-cooper merged 11 commits intovyperlang:masterfrom
Conversation
|
slight performance regression here (200-300ms for full size contract) |
charles-cooper
left a comment
charles-cooper
left a comment
There was a problem hiding this comment.
lgtm, altho that performance regression makes me a bit nervous. @harkal i pushed a fix for variable printing, there were some variables like %%1 being printed out.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4404 +/- ##
==========================================
- Coverage 90.33% 88.67% -1.67%
==========================================
Files 115 115
Lines 16236 16236
Branches 2733 2732 -1
==========================================
- Hits 14667 14397 -270
- Misses 1109 1319 +210
- Partials 460 520 +60 ☔ View full report in Codecov by Sentry. |
…per into feat/cleanup_variable_versions
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| def __hash__(self) -> int: | ||
| return hash(self.value) | ||
| if self._hash is None: |
Check warning
Code scanning / CodeQL
`__eq__` not overridden when adding attributes
| if version > 0: | ||
| self.value = f"{name}:{version}" | ||
| else: | ||
| self.value = name |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class
| else: | ||
| self.value = name | ||
|
|
||
| @property |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class
3 participants
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture