Skip to content

feat[venom]: allow alphanumeric variables and source comments#4403

Merged
charles-cooper merged 4 commits intovyperlang:masterfrom
harkal:feat/venom_parser_improvements
Dec 17, 2024
Merged

feat[venom]: allow alphanumeric variables and source comments#4403
charles-cooper merged 4 commits intovyperlang:masterfrom
harkal:feat/venom_parser_improvements

Conversation

@harkal
Copy link
Copy Markdown
Collaborator

@harkal harkal commented Dec 17, 2024

What I did

Implemented alphanumeric variables, and source code comments

How I did it

How to verify it

Commit message

This commit implements minor improvements to the venom parser. 
Specifically it allows for alphanumeric variable names, and for single 
line source code comments in various styles: ";" "#" and "//"

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@harkal harkal marked this pull request as ready for review December 17, 2024 14:18
since the grammar rule no longer requires that the second part is an
int, parse it inside of the `VAR_IDENT` rule
@charles-cooper charles-cooper changed the title feat[venom]: allow alphanumeric variables, and source comments feat[venom]: allow alphanumeric variables and source comments Dec 17, 2024
@charles-cooper charles-cooper enabled auto-merge (squash) December 17, 2024 14:30
@charles-cooper charles-cooper merged commit ebe26a6 into vyperlang:master Dec 17, 2024
@harkal harkal deleted the feat/venom_parser_improvements branch December 17, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants