refactor[venom]: add new venom test machinery#4401
Merged
charles-cooper merged 9 commits intovyperlang:masterfrom Dec 17, 2024
Merged
refactor[venom]: add new venom test machinery#4401charles-cooper merged 9 commits intovyperlang:masterfrom
charles-cooper merged 9 commits intovyperlang:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4401 +/- ##
===========================================
- Coverage 91.11% 50.92% -40.20%
===========================================
Files 115 115
Lines 16225 16227 +2
Branches 2728 2729 +1
===========================================
- Hits 14784 8264 -6520
- Misses 1006 7345 +6339
- Partials 435 618 +183 ☔ View full report in Codecov by Sentry. |
HodanPlodky
reviewed
Dec 17, 2024
HodanPlodky
reviewed
Dec 17, 2024
| s += opcode | ||
| operands = self.operands | ||
| if opcode not in ["jmp", "jnz", "invoke"]: | ||
| if opcode not in ("jmp", "jnz", "invoke"): |
Collaborator
There was a problem hiding this comment.
I now this is not necessarily part of the PR but there it should be self.opcode no? since the opcode contains space after original opcode so body of this if is unreachable right now (I have noticed it when thinking about order of operands in jnz)
Member
Author
Co-authored-by: HodanPlodky <[email protected]>
harkal
approved these changes
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
refactor venom tests with new parsing machinery. it should make tests easier to read. add an example of the new testing style
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture