fix[ux]: fix false positive for overflow in type checker#4385
Merged
charles-cooper merged 5 commits intovyperlang:masterfrom Dec 9, 2024
Merged
fix[ux]: fix false positive for overflow in type checker#4385charles-cooper merged 5 commits intovyperlang:masterfrom
charles-cooper merged 5 commits intovyperlang:masterfrom
Conversation
charles-cooper
changed the title
charles-cooper
requested review from
cyberthirst
and removed request for
cyberthirst
cyberthirst
approved these changes
Dec 9, 2024
charles-cooper
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix #4383
How I did it
Catch
OverflowExceptionwhen finding possible types forBinOpnode.How to verify it
See test.
Commit message
Description for the changelog
Cute Animal Picture