feat[venom]: add calloca instruction#4376
Merged
charles-cooper merged 19 commits intovyperlang:masterfrom Mar 14, 2025
Merged
Conversation
this instruction is meant to help match call-site allocations with pallocas (inside the callee).
charles-cooper
force-pushed
the
feat/venom/calloca
branch
from
a5caad1 to
c647456
Compare
harkal
approved these changes
Dec 9, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4376 +/- ##
==========================================
+ Coverage 92.22% 92.24% +0.01%
==========================================
Files 123 123
Lines 17472 17500 +28
Branches 2955 2960 +5
==========================================
+ Hits 16114 16142 +28
Misses 946 946
Partials 412 412 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cyberthirst
approved these changes
Feb 18, 2025
Collaborator
cyberthirst
left a comment
cyberthirst
left a comment
There was a problem hiding this comment.
only checked the minimalist legacy update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
promote the callee buffer (allocated at call site) to an alloca-like instruction.
there are a couple minor regressions in here:
one is fixed in #4419
the other is filed in #4420.
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture