fix[venom]: add missing extcodesize+hash effects#4373
Merged
charles-cooper merged 3 commits intovyperlang:masterfrom Nov 26, 2024
Merged
fix[venom]: add missing extcodesize+hash effects#4373charles-cooper merged 3 commits intovyperlang:masterfrom
charles-cooper merged 3 commits intovyperlang:masterfrom
Conversation
per title -- effects.py was missing extcodesize and extcodehash effects.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4373 +/- ##
==========================================
- Coverage 91.27% 88.28% -2.99%
==========================================
Files 112 112
Lines 16025 16025
Branches 2696 2696
==========================================
- Hits 14627 14148 -479
- Misses 966 1344 +378
- Partials 432 533 +101 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
harkal
approved these changes
Nov 26, 2024
cyberthirst
approved these changes
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
per title -- effects.py was missing extcodesize and extcodehash effects.
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture