fix[lang]!: forbid calling __default__#4371
Merged
charles-cooper merged 9 commits intovyperlang:masterfrom Mar 25, 2025
Merged
Conversation
| from vyper.semantics.data_locations import DataLocation | ||
| from vyper.semantics.types.base import TYPE_T, VyperType, is_type_t | ||
| from vyper.semantics.types.function import ContractFunctionT | ||
| from vyper.semantics.types.function import ContractFunctionT, MemberFunctionT |
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
| from vyper.semantics.data_locations import DataLocation | ||
| from vyper.semantics.types.base import TYPE_T, VyperType, is_type_t | ||
| from vyper.semantics.types.function import ContractFunctionT | ||
| from vyper.semantics.types.function import ContractFunctionT, MemberFunctionT |
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
Collaborator
|
we disallow |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4371 +/- ##
=======================================
Coverage 92.36% 92.36%
=======================================
Files 123 123
Lines 17527 17531 +4
Branches 2958 2959 +1
=======================================
+ Hits 16189 16193 +4
Misses 934 934
Partials 404 404 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cyberthirst
reviewed
Mar 24, 2025
| @external | ||
| def bar(): | ||
| foo:int128 = 0 | ||
| foo = staticcall lib1.__at__(self).__default__() |
Collaborator
There was a problem hiding this comment.
maybe we should also test the interface variant:
@external
def bar():
foo:int128 = 0
foo = staticcall lib1.__interface__(self).__default__()
Co-authored-by: Charles Cooper <[email protected]>
19c0d14 to
13e7421
Compare
charles-cooper
approved these changes
Mar 25, 2025
Member
|
lgtm. @cyberthirst anything else you want to see? |
: forbid calling __default__`
: forbid calling __default__`__default__
cyberthirst
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Forbid calling
__default__bystaticcallandextcall. Depends on #4090.Edit: Added dependency on the PR.
How I did it
In
validatefunctions check the attribute name if present.How to verify it
Commit message
Description for the changelog
Cute Animal Picture