refactor[venom]: optimize lattice evaluation#4368
Merged
charles-cooper merged 10 commits intovyperlang:masterfrom Nov 20, 2024
Merged
refactor[venom]: optimize lattice evaluation#4368charles-cooper merged 10 commits intovyperlang:masterfrom
charles-cooper merged 10 commits intovyperlang:masterfrom
Conversation
harkal
changed the title
charles-cooper
approved these changes
Nov 20, 2024
charles-cooper
changed the title
Member
charles-cooper
left a comment
charles-cooper
left a comment
There was a problem hiding this comment.
actually made a couple small suggestions offline -- @harkal ping me again when you have considered them
charles-cooper
approved these changes
Nov 20, 2024
Member
charles-cooper
left a comment
charles-cooper
left a comment
There was a problem hiding this comment.
looks good. i think there might be other cases where we should actually be adding to ssa work items but maybe out of scope for this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Small optimization of the lattice evaluation method, along with some dead code removal.
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture