fix[lang]: use folded node for typechecking#4365
Merged
charles-cooper merged 12 commits intovyperlang:masterfrom Nov 23, 2024
Merged
fix[lang]: use folded node for typechecking#4365charles-cooper merged 12 commits intovyperlang:masterfrom
charles-cooper merged 12 commits intovyperlang:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4365 +/- ##
==========================================
- Coverage 90.99% 88.81% -2.18%
==========================================
Files 112 112
Lines 16017 16018 +1
Branches 2696 2696
==========================================
- Hits 14574 14226 -348
- Misses 1005 1281 +276
- Partials 438 511 +73 ☔ View full report in Codecov by Sentry. |
tserg
changed the title
tserg
commented
Nov 20, 2024
charles-cooper
requested changes
Nov 20, 2024
Member
charles-cooper
left a comment
charles-cooper
left a comment
There was a problem hiding this comment.
add another test for conversion of invalid bytestrings
Co-authored-by: Charles Cooper <[email protected]>
charles-cooper
approved these changes
Nov 21, 2024
Member
charles-cooper
left a comment
charles-cooper
left a comment
There was a problem hiding this comment.
lgtm. @cyberthirst is there anything you want to see here?
cyberthirst
reviewed
Nov 23, 2024
cyberthirst
approved these changes
Nov 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix #4190, #4360.
How I did it
Use the reduced node for typechecking.
How to verify it
See added tests
Commit message
Description for the changelog
Fix compilation for valid syntax with foldable values
Cute Animal Picture