refactor[parser]: remove ASTTokens#4364
Merged
charles-cooper merged 48 commits intovyperlang:masterfrom Jan 12, 2025
Merged
Conversation
Collaborator
|
i find the name |
Collaborator
|
can we generalize this code? it's pretty much the same thing 3 times Lines 289 to 324 in 5c1fb8b |
cyberthirst
reviewed
Jan 12, 2025
vyper/ast/pre_parser.py
Outdated
| # A mapping of class names to their original class types. | ||
| modification_offsets: dict[tuple[int, int], str] | ||
|
|
||
| # Magic adjustments |
Collaborator
There was a problem hiding this comment.
let's make a better comment hehe
cyberthirst
approved these changes
Jan 12, 2025
This was referenced Jan 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
remove asttokens from the parse machinery, since the method is buggy (see below bugs) and slow (#4272). brings down parse time (time spent in ast generation) between 40-70%.
fixes multiple tokenizer-related bugs, including
How I did it
another way to adjust tokens
How to verify it
Commit message
Description for the changelog
Cute Animal Picture