feat[venom]: make cfg scheduler "stack aware"#4356
Merged
charles-cooper merged 4 commits intovyperlang:masterfrom Nov 12, 2024
Merged
feat[venom]: make cfg scheduler "stack aware"#4356charles-cooper merged 4 commits intovyperlang:masterfrom
charles-cooper merged 4 commits intovyperlang:masterfrom
Conversation
this is a step towards making the cfg traversal order more "stack aware". previously we would blindly try to remove `iszero` instructions before a `jnz`. now, the heuristic is based on which basic block has a smaller sized dependency on this basic block. only if the two cfg_out blocks have the same sized dependency, then we try to remove the iszero.
harkal
approved these changes
Nov 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4356 +/- ##
===========================================
- Coverage 91.37% 45.99% -45.39%
===========================================
Files 112 112
Lines 15927 15940 +13
Branches 2693 2694 +1
===========================================
- Hits 14554 7331 -7223
- Misses 939 8050 +7111
- Partials 434 559 +125 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture