feat[venom]: merge memory writes#4341
Merged
charles-cooper merged 157 commits intovyperlang:masterfrom Dec 18, 2024
Merged
Conversation
Member
|
looking very nice |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4341 +/- ##
==========================================
- Coverage 91.12% 90.26% -0.86%
==========================================
Files 115 116 +1
Lines 16235 16476 +241
Branches 2732 2778 +46
==========================================
+ Hits 14794 14872 +78
- Misses 1004 1141 +137
- Partials 437 463 +26 ☔ View full report in Codecov by Sentry. |
… for better understanding)
…d similar but possible case
| MemMergePass(ac, fn).run_pass() | ||
|
|
||
| bb = next(next(iter(ctx.functions.values())).get_basic_blocks()) | ||
| assert bb.instructions[0].opcode == "mcopy" |
Member
There was a problem hiding this comment.
i think here we could have pre/post comparison
charles-cooper
approved these changes
Dec 18, 2024
Member
charles-cooper
left a comment
There was a problem hiding this comment.
lgtm. @HodanPlodky added some final tweaks to the test comments, will merge if they are ok
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Reimplementation of methods from original pipeline optimizer into the venom pipeline, that handled merging of the multiple memory operations that writes into the continuous chuck of the memory into one instruction that does in batch.
How I did it
Created new pass for this purpose
How to verify it
I have written new tests
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture