refactor[venom]: update translator for deploy instruction#4318
Merged
charles-cooper merged 1 commit intovyperlang:masterfrom Oct 29, 2024
Merged
refactor[venom]: update translator for deploy instruction#4318charles-cooper merged 1 commit intovyperlang:masterfrom
deploy instruction#4318charles-cooper merged 1 commit intovyperlang:masterfrom
Conversation
this commit updates `ir_node_to_venom.py` for the `deploy` instruction to properly emit the `exit` instruction. it also removes places in the translator where the `exit` instruction was improperly emitted. misc: - update style to continue early in the loop rather than nest.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4318 +/- ##
==========================================
- Coverage 91.40% 90.21% -1.20%
==========================================
Files 112 112
Lines 15927 15927
Branches 2694 2693 -1
==========================================
- Hits 14558 14368 -190
- Misses 935 1093 +158
- Partials 434 466 +32 ☔ View full report in Codecov by Sentry. |
HodanPlodky
approved these changes
Oct 21, 2024
harkal
approved these changes
Oct 29, 2024
charles-cooper
changed the title
deploy instruction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this commit updates
ir_node_to_venom.pyfor thedeployinstruction to properly emit theexitinstruction. it also removes places in the translator where theexitinstruction was improperly emitted.misc:
What I did
fix #4317
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture