fix[ci]: fix commithash calculation for pypi release#4309
Merged
charles-cooper merged 2 commits intovyperlang:masterfrom Oct 15, 2024
Merged
fix[ci]: fix commithash calculation for pypi release#4309charles-cooper merged 2 commits intovyperlang:masterfrom
charles-cooper merged 2 commits intovyperlang:masterfrom
Conversation
there is a mismatch between the commit hash in the binary of the github release vs the pypi release. for example, ```bash ~ $ vyper --version # pipx install vyper==0.4.0 0.4.0+commit.e9db8d9 ``` ```bash ~ $ .vvm/vyper-0.4.0 --version 0.4.0+commit.e9db8d9f ``` this is due to how git computes the shorthash. when checkout is run for release-pypi.yml, it doesn't fetch the full commit history, and so there are fewer commits, so `git rev-parse --short HEAD` returns a smaller fingerprint for the commit hash. this commit amends the pypi release checkout step so that it matches the github release workflow.
Member
Author
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4309 +/- ##
===========================================
- Coverage 91.40% 46.12% -45.29%
===========================================
Files 112 112
Lines 15917 15923 +6
Branches 2693 2693
===========================================
- Hits 14549 7344 -7205
- Misses 934 8025 +7091
- Partials 434 554 +120 ☔ View full report in Codecov by Sentry. |
fubuloubu
approved these changes
Oct 15, 2024
cyberthirst
approved these changes
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What I did
fix #4308
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture