refactor[venom]: move commutative instruction set#4307
Merged
charles-cooper merged 2 commits intovyperlang:masterfrom Oct 15, 2024
Merged
refactor[venom]: move commutative instruction set#4307charles-cooper merged 2 commits intovyperlang:masterfrom
charles-cooper merged 2 commits intovyperlang:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4307 +/- ##
==========================================
- Coverage 91.40% 88.74% -2.67%
==========================================
Files 112 112
Lines 15920 15923 +3
Branches 2693 2693
==========================================
- Hits 14552 14131 -421
- Misses 934 1274 +340
- Partials 434 518 +84 ☔ View full report in Codecov by Sentry. |
harkal
approved these changes
Oct 15, 2024
charles-cooper
changed the title
charles-cooper
approved these changes
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Moved the commutative instruction set from
venom_to_assembly.pyinto thebasicblock.pyand added the convenience method inIRInstructionHow to verify it
test
Commit message
Description for the changelog
Cute Animal Picture