fix[lang]: fix recursive interface imports#4303
Merged
charles-cooper merged 2 commits intovyperlang:masterfrom Oct 14, 2024
Merged
fix[lang]: fix recursive interface imports#4303charles-cooper merged 2 commits intovyperlang:masterfrom
charles-cooper merged 2 commits intovyperlang:masterfrom
Conversation
fix a bug where imports inside of interfaces are not recursed into in the import resolution pass. this is a regression in 6843e79.
fubuloubu
approved these changes
Oct 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4303 +/- ##
==========================================
- Coverage 91.43% 90.23% -1.20%
==========================================
Files 112 112
Lines 15916 15917 +1
Branches 2693 2693
==========================================
- Hits 14552 14363 -189
- Misses 930 1080 +150
- Partials 434 474 +40 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix a bug where imports inside of interfaces are not recursed into in the import resolution pass. this is a regression in 6843e79.
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture