Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.57%. Comparing base (e0fc53a) to head (5f2cd05).
Report is 9 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (e0fc53a) and HEAD (5f2cd05). Click for more details.

HEAD has 136 uploads less than BASE

Flag	BASE (e0fc53a)	HEAD (5f2cd05)
	137	1

@@             Coverage Diff             @@
##           master    #4286       +/-   ##
===========================================
- Coverage   91.27%   45.57%   -45.71%     
===========================================
  Files         112      112               
  Lines       16017    16017               
  Branches     2696     2696               
===========================================
- Hits        14619     7299     -7320     
- Misses        966     8159     +7193     
- Partials      432      559      +127     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

i think the PR addresses the issue

but we're still overriding error messages for less concrete ones in set_error_msg

following will fail

def test_error_map_with_user_error2():
    code = """
@external
def foo(i: uint256):
    a: DynArray[uint256, 10] = [1]
    a[i % 10] = 2
    """
    error_map = compile_code(code, output_formats=["source_map"])["source_map"]["error_map"]
    assert "safemod" in error_map.values()

as it will get overwritten by

 ix.set_error_msg(f"{parent.typ} bounds check")

i think the PR addresses the issue

but we're still overriding error messages for less concrete ones in set_error_msg

following will fail

def test_error_map_with_user_error2():
    code = """
@external
def foo(i: uint256):
    a: DynArray[uint256, 10] = [1]
    a[i % 10] = 2
    """
    error_map = compile_code(code, output_formats=["source_map"])["source_map"]["error_map"]
    assert "safemod" in error_map.values()

as it will get overwritten by

 ix.set_error_msg(f"{parent.typ} bounds check")

this is a good catch. @sandbubbles can you add the guard to set_error_msg() as you had before so it blocks the recursion if error msg is already set?

i think the PR addresses the issue
but we're still overriding error messages for less concrete ones in set_error_msg
following will fail

def test_error_map_with_user_error2():
    code = """
@external
def foo(i: uint256):
    a: DynArray[uint256, 10] = [1]
    a[i % 10] = 2
    """
    error_map = compile_code(code, output_formats=["source_map"])["source_map"]["error_map"]
    assert "safemod" in error_map.values()

as it will get overwritten by

 ix.set_error_msg(f"{parent.typ} bounds check")

this is a good catch. @sandbubbles can you add the guard to set_error_msg() as you had before so it blocks the recursion if error msg is already set?

Done:), should be ready for another check.

@sandbubbles please write out a commit message for this pull request :)