feat[venom]: add binop optimizations#4281
Merged
charles-cooper merged 219 commits intovyperlang:masterfrom Jan 20, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4281 +/- ##
==========================================
+ Coverage 92.01% 92.09% +0.08%
==========================================
Files 119 119
Lines 16692 16931 +239
Branches 2805 2865 +60
==========================================
+ Hits 15359 15593 +234
- Misses 915 919 +4
- Partials 418 419 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Charles Cooper <[email protected]>
charles-cooper
approved these changes
Jan 15, 2025
Member
charles-cooper
left a comment
There was a problem hiding this comment.
very thorough! i reviewed that every single rule introduced in this PR has a corresponding test case. also added variants for some commutative ops.
depend on sccp being run afterward
harkal
added a commit
to harkal/vyper
that referenced
this pull request
Jan 22, 2025
This reverts commit 9a2cb2e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Started reimplementing the binary operation optimization and some additional from original pipeline to venom pipeline
How I did it
The optimization are done in the
AlgebraicOptimizationPasssince the types of optimizations nicely slots into the purpose of the pass. Most of the logic is directly taken from the original pipelineHow to verify it
Commit message
Description for the changelog
Cute Animal Picture